Skip to content

chore(logs): reference interfaces#36566

Merged
mergify[bot] merged 8 commits intomainfrom
huijbers/reference-interfaces-logs
Jan 12, 2026
Merged

chore(logs): reference interfaces#36566
mergify[bot] merged 8 commits intomainfrom
huijbers/reference-interfaces-logs

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 5, 2026

Reference interfaces for L2s, like #35271.

"chore" because I plan to make a lot of these PRs and they're not adding value to the changelog.

(Generated with AI)

BREAKING CHANGE: the return types of FlowLogDestination.bind() and ICluster.executeCommandConfiguration now contain an ILogGroupRef instead of an ILogGroup, which guarantees less. These fields are for communication between constructs, and their values should not be used by application builders. If they do, they will need to add a cast or a type check.

Reference interfaces for L2s, like #35271.

"chore" because I plan to make a lot of these PRs and they're not adding value to the changelog.

(Generated with AI)
@rix0rrr rix0rrr requested a review from a team January 5, 2026 13:10
@github-actions github-actions bot added the p2 label Jan 5, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team January 5, 2026 13:10
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 5, 2026
@rix0rrr rix0rrr marked this pull request as ready for review January 7, 2026 13:42
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@rix0rrr rix0rrr added the pr-linter/exempt-breaking-change The PR linter will not require stability in stable modules label Jan 9, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 9, 2026 09:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 9, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2026

Merge Queue Status

✅ The pull request has been merged at edbe91d

This pull request spent 1 hour 41 minutes 57 seconds in the queue, including 40 minutes 57 seconds running CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = validate-pr
    • check-neutral = validate-pr
    • check-skipped = validate-pr
  • any of [🛡 GitHub branch protection]:
    • check-success = build
    • check-neutral = build
    • check-skipped = build

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 12, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5b426b8 into main Jan 12, 2026
17 of 18 checks passed
@mergify mergify bot deleted the huijbers/reference-interfaces-logs branch January 12, 2026 12:57
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-breaking-change The PR linter will not require stability in stable modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants